Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update openAPI spec to remove SourcePackage #2175

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

crozzy
Copy link
Collaborator

@crozzy crozzy commented Nov 13, 2024

This update removes SourcePackage and replaces the Source definition with the Package schema. This was unsupported in the Swagger UI for a long time but has apparently recently been fixed.

@crozzy crozzy requested a review from a team as a code owner November 13, 2024 20:04
@crozzy crozzy requested review from RTann and removed request for a team November 13, 2024 20:04
@crozzy crozzy force-pushed the update-openapi-docs branch from f802295 to 94d6c61 Compare November 13, 2024 21:48
@crozzy
Copy link
Collaborator Author

crozzy commented Nov 14, 2024

Ran a test with OPA and lgtm:
./opa eval -i ubi9_latest.json -d clair.rego "data.example.errors[x]" | jq
Previously

          "value": {
            "desc": "Invalid type. Expected: string, given: object",
            "error": "packages.qwXrTBMmqxKqFN9XQ0/+tg==.source.source: Invalid type. Expected: string, given: object",
            "field": "packages.qwXrTBMmqxKqFN9XQ0/+tg==.source.source",
            "type": "invalid_type"
          },

Now:

{}

This update removes SourcePackage and replaces the Source definition
with the Package schema. This was unsupported in the Swagger UI for a
long time but has apparently recently been fixed.

Signed-off-by: crozzy <joseph.crosland@gmail.com>
@crozzy crozzy force-pushed the update-openapi-docs branch from 94d6c61 to dde57fc Compare November 18, 2024 17:35
@crozzy
Copy link
Collaborator Author

crozzy commented Nov 18, 2024

/fast-forward

@github-actions github-actions bot merged commit dde57fc into quay:main Nov 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants